Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 985763004: Ensure that the base::debug crash key functions can be used from chrome.exe. (Closed)

Created:
5 years, 9 months ago by erikwright (departed)
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, kalyank, sadrul, Sigurður Ásgeirsson, chrisha, robertshield
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure that the base::debug crash key functions can be used from chrome.exe. BUG=460512 Committed: https://crrev.com/04de251bfadddc51f7a0848d423165e7019edc1d Cr-Commit-Position: refs/heads/master@{#319525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M components/crash/app/breakpad_win.cc View 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikwright (departed)
rsesek: PTAL.
5 years, 9 months ago (2015-03-06 21:15:47 UTC) #2
Robert Sesek
LGTM
5 years, 9 months ago (2015-03-06 22:00:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985763004/1
5 years, 9 months ago (2015-03-06 22:02:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 23:25:49 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 23:26:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04de251bfadddc51f7a0848d423165e7019edc1d
Cr-Commit-Position: refs/heads/master@{#319525}

Powered by Google App Engine
This is Rietveld 408576698