Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 985753002: Revert of Add support for escaped target names in isolate driver. (Closed)

Created:
5 years, 9 months ago by Marc Treib
Modified:
5 years, 9 months ago
CC:
chromium-reviews, falken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add support for escaped target names in isolate driver. (patchset #6 id:100001 of https://codereview.chromium.org/970203003/) Reason for revert: Likely broke Mac 10.9 dbg: http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/3709 Original issue's description: > Add support for escaped target names in isolate driver. > > Currently the isolate_driver.py which creates the dependency files > used by the isolate system, does a simple split on all spaces when > trying to identify targets. > > This can fail if the target name contains a space in the name. In > ninja, spaces are escaped with a $-prefix. An example would be > 'Content$ Shell$ Helper.app'. > > This CL adds support for such target names and ensures that they > stay as one item. > > BUG=462248 > > Committed: https://crrev.com/8fb598c1b7b9a6b944e2ec15e989e80cdf7522c0 > Cr-Commit-Position: refs/heads/master@{#319356} TBR=avi@chromium.org,maruel@chromium.org,falken@chromium.org,vadimsh@chromium.org,nyquist@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=462248 Committed: https://crrev.com/f4e514de66bc88423b42ccbde1b7f25a5d46b2d9 Cr-Commit-Position: refs/heads/master@{#319448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M tools/isolate_driver.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marc Treib
Created Revert of Add support for escaped target names in isolate driver.
5 years, 9 months ago (2015-03-06 15:24:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985753002/1
5 years, 9 months ago (2015-03-06 15:24:49 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 15:25:39 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 15:26:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e514de66bc88423b42ccbde1b7f25a5d46b2d9
Cr-Commit-Position: refs/heads/master@{#319448}

Powered by Google App Engine
This is Rietveld 408576698