Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 985713005: Introduce cfi_vptr build flag. (Closed)

Created:
5 years, 9 months ago by pcc1
Modified:
5 years, 9 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce cfi_vptr build flag. This flag enables Clang's new control flow integrity mechanism for virtual table calls, which is documented at: http://clang.llvm.org/docs/ControlFlowIntegrity.html BUG=464797 R=thakis@chromium.org Committed: https://crrev.com/980ad01235a474d721c4e093488b88ec986295cf Cr-Commit-Position: refs/heads/master@{#319534}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Set use_lto=1 automatically if cfi_vptr is set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M build/common.gypi View 1 4 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
pcc1
5 years, 9 months ago (2015-03-06 20:01:58 UTC) #1
Nico
lgtm https://codereview.chromium.org/985713005/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/985713005/diff/1/build/common.gypi#newcode3003 build/common.gypi:3003: ['(use_lto==1 or cfi_vptr==1) and (target_arch=="ia32" or target_arch=="x64")', { ...
5 years, 9 months ago (2015-03-06 21:13:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985713005/20001
5 years, 9 months ago (2015-03-06 21:39:56 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-07 00:16:49 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-07 00:17:28 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/980ad01235a474d721c4e093488b88ec986295cf
Cr-Commit-Position: refs/heads/master@{#319534}

Powered by Google App Engine
This is Rietveld 408576698