Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 985693004: Remove the old signature of NotificationManager::closePersistent(). (Closed)

Created:
5 years, 9 months ago by Peter Beverloo
Modified:
5 years, 9 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@n-close-data
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the old signature of NotificationManager::closePersistent(). The origin now is included, and Blink has been updated to pass it in. This is part of a three-sided patch: [1] https://codereview.chromium.org/982313002/ [2] https://codereview.chromium.org/985063002/ [3] This patch. BUG=447628 Committed: https://crrev.com/a31bffe13b2b4abc6d8f93347f4d2d8cca1e7687 Cr-Commit-Position: refs/heads/master@{#320928}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M content/child/notifications/notification_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Peter Beverloo
PTAL :)
5 years, 9 months ago (2015-03-06 15:53:34 UTC) #2
Mike West
lgtm
5 years, 9 months ago (2015-03-06 16:11:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985693004/20001
5 years, 9 months ago (2015-03-17 14:26:25 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 16:09:45 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 16:10:42 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a31bffe13b2b4abc6d8f93347f4d2d8cca1e7687
Cr-Commit-Position: refs/heads/master@{#320928}

Powered by Google App Engine
This is Rietveld 408576698