Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 985663003: Replacing 0 with nullptr (Closed)

Created:
5 years, 9 months ago by samahto
Modified:
5 years, 9 months ago
Reviewers:
keishi, tkent, eae, kochi
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replacing 0 with nullptr in HTMLTextAreaElement.cpp BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191824

Patch Set 1 #

Patch Set 2 : Updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/html/HTMLTextAreaElement.cpp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
samahto
5 years, 9 months ago (2015-03-07 07:09:04 UTC) #2
kochi
lgtm
5 years, 9 months ago (2015-03-09 09:30:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985663003/20001
5 years, 9 months ago (2015-03-09 14:00:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/28547)
5 years, 9 months ago (2015-03-09 14:15:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985663003/20001
5 years, 9 months ago (2015-03-09 18:03:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/28572)
5 years, 9 months ago (2015-03-09 18:21:09 UTC) #11
kochi
On 2015/03/09 at 18:21:09, commit-bot wrote: > Try jobs failed on following builders: > blink_presubmit ...
5 years, 9 months ago (2015-03-10 01:01:51 UTC) #12
kochi
On 2015/03/10 at 01:01:51, Takayoshi Kochi wrote: > On 2015/03/09 at 18:21:09, commit-bot wrote: > ...
5 years, 9 months ago (2015-03-10 06:36:24 UTC) #13
samahto
On 2015/03/10 06:36:24, Takayoshi Kochi wrote: > On 2015/03/10 at 01:01:51, Takayoshi Kochi wrote: > ...
5 years, 9 months ago (2015-03-10 16:10:42 UTC) #14
samahto
Need approvals from OWNERS
5 years, 9 months ago (2015-03-13 05:31:00 UTC) #16
tkent
lgtm
5 years, 9 months ago (2015-03-13 05:48:34 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985663003/20001
5 years, 9 months ago (2015-03-13 05:48:39 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 08:55:51 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191824

Powered by Google App Engine
This is Rietveld 408576698