|
|
DescriptionReplacing 0 with nullptr in HTMLTextAreaElement.cpp
BUG=None
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191824
Patch Set 1 #Patch Set 2 : Updated. #Messages
Total messages: 20 (7 generated)
samahto@cisco.com changed reviewers: + eae@chromium.org, keishi@chromium.org, kochi@chromium.org
lgtm
The CQ bit was checked by samahto@cisco.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985663003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)
The CQ bit was checked by samahto@cisco.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985663003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)
On 2015/03/09 at 18:21:09, commit-bot wrote: > Try jobs failed on following builders: > blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...) samahto, you need another LGTM from one of reviewers in the OWNERS file.
On 2015/03/10 at 01:01:51, Takayoshi Kochi wrote: > On 2015/03/09 at 18:21:09, commit-bot wrote: > > Try jobs failed on following builders: > > blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...) > > samahto, you need another LGTM from one of reviewers in the OWNERS file. And you need to sign CLA, if you want to contribute from outside Google for the first time: see http://dev.chromium.org/developers/contributing-code/external-contributor-che...
On 2015/03/10 06:36:24, Takayoshi Kochi wrote: > On 2015/03/10 at 01:01:51, Takayoshi Kochi wrote: > > On 2015/03/09 at 18:21:09, commit-bot wrote: > > > Try jobs failed on following builders: > > > blink_presubmit on tryserver.blink (JOB_FAILED, > http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...) > > > > samahto, you need another LGTM from one of reviewers in the OWNERS file. > > And you need to sign CLA, if you want to contribute from outside Google for the > first time: > see > http://dev.chromium.org/developers/contributing-code/external-contributor-che... Yeah, I will check with OWNERS. Actually its not first patch. I mean all formalities are complete.
samahto@cisco.com changed reviewers: + tkent@chromium.org
Need approvals from OWNERS
The CQ bit was checked by tkent@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985663003/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=191824 |