content/browser/service_worker/service_worker_context_observer.h - Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_observer.h

Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed to push model Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/protocol/service_worker_handler.cc ('K') | « content/browser/service_worker/service_worker_context_core.cc ('k') | content/browser/service_worker/service_worker_context_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_observer.h

diff --git a/content/browser/service_worker/service_worker_context_observer.h b/content/browser/service_worker/service_worker_context_observer.h

index dbc79bacac6096173b508a61301f028b41a128aa..145a2507c5fc93ac3677e843acfe61c633693772 100644

--- a/content/browser/service_worker/service_worker_context_observer.h

+++ b/content/browser/service_worker/service_worker_context_observer.h

@@ -43,12 +43,7 @@ class ServiceWorkerContextObserver {

const int line_number;

const GURL source_url;

};

- virtual void OnWorkerStarted(int64 version_id,

- int process_id,

- int thread_id) {}

- virtual void OnWorkerStopped(int64 version_id,

- int process_id,

- int thread_id) {}

+ virtual void OnRunningStateChanged(int64 version_id) {}

virtual void OnVersionStateChanged(int64 version_id) {}

virtual void OnErrorReported(int64 version_id,

int process_id,

@@ -58,7 +53,8 @@ class ServiceWorkerContextObserver {

int process_id,

int thread_id,

const ConsoleMessage& message) {}

- virtual void OnRegistrationStored(const GURL& pattern) {}

+ virtual void OnRegistrationStored(int64 registration_id,

+ const GURL& pattern) {}

virtual void OnRegistrationDeleted(int64 registration_id,

const GURL& pattern) {}