content/browser/resources/service_worker/serviceworker_internals.js - Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/resources/service_worker/serviceworker_internals.js

Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed to push model Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/devtools/protocol/service_worker_handler.cc ('K') | « content/browser/devtools/render_frame_devtools_agent_host.cc ('k') | content/browser/service_worker/embedded_worker_instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/resources/service_worker/serviceworker_internals.js

diff --git a/content/browser/resources/service_worker/serviceworker_internals.js b/content/browser/resources/service_worker/serviceworker_internals.js

index 93bf437fbc5eef154eb63251ded4553f4f6283fc..b5c85eebfab5033ff7a75bad61acd6a7f4a451a2 100644

--- a/content/browser/resources/service_worker/serviceworker_internals.js

+++ b/content/browser/resources/service_worker/serviceworker_internals.js

@@ -192,11 +192,7 @@ cr.define('serviceworker', function() {

}

- function onWorkerStarted(partition_id, version_id, process_id, thread_id) {

- update();

- }

- function onWorkerStopped(partition_id, version_id, process_id, thread_id) {

+ function onRunningStateChanged(partition_id, version_id) {

update();

}

@@ -258,8 +254,7 @@ cr.define('serviceworker', function() {

onOptions: onOptions,

onOperationComplete: onOperationComplete,

onPartitionData: onPartitionData,

- onWorkerStarted: onWorkerStarted,

- onWorkerStopped: onWorkerStopped,

+ onRunningStateChanged: onRunningStateChanged,

onErrorReported: onErrorReported,

onConsoleMessageReported: onConsoleMessageReported,

onVersionStateChanged: onVersionStateChanged,