Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2461)

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: override Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_core.cc
diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc
index 4ae67d4155b62f38144cfd2d4f9c069726f5f58e..c2e9553f15397f93ddb19d8bdf873a41af0c8bbf 100644
--- a/content/browser/service_worker/service_worker_context_core.cc
+++ b/content/browser/service_worker/service_worker_context_core.cc
@@ -304,7 +304,7 @@ void ServiceWorkerContextCore::RegistrationComplete(
if (observer_list_.get()) {
observer_list_->Notify(FROM_HERE,
&ServiceWorkerContextObserver::OnRegistrationStored,
- pattern);
+ registration->id(), pattern);
}
}
@@ -439,22 +439,13 @@ void ServiceWorkerContextCore::TransferProviderHostIn(
delete temp;
}
-void ServiceWorkerContextCore::OnWorkerStarted(ServiceWorkerVersion* version) {
- if (!observer_list_.get())
- return;
- observer_list_->Notify(
- FROM_HERE, &ServiceWorkerContextObserver::OnWorkerStarted,
- version->version_id(), version->embedded_worker()->process_id(),
- version->embedded_worker()->thread_id());
-}
-
-void ServiceWorkerContextCore::OnWorkerStopped(ServiceWorkerVersion* version) {
+void ServiceWorkerContextCore::OnRunningStateChanged(
+ ServiceWorkerVersion* version) {
if (!observer_list_.get())
return;
- observer_list_->Notify(
- FROM_HERE, &ServiceWorkerContextObserver::OnWorkerStopped,
- version->version_id(), version->embedded_worker()->process_id(),
- version->embedded_worker()->thread_id());
+ observer_list_->Notify(FROM_HERE,
+ &ServiceWorkerContextObserver::OnRunningStateChanged,
+ version->version_id());
}
void ServiceWorkerContextCore::OnVersionStateChanged(

Powered by Google App Engine
This is Rietveld 408576698