Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: content/browser/service_worker/embedded_worker_instance.cc

Issue 985663002: Implement ServiceWorkerRegistration related DevTools events [2/2 chromium] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: override Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_instance.cc
diff --git a/content/browser/service_worker/embedded_worker_instance.cc b/content/browser/service_worker/embedded_worker_instance.cc
index e7b27c3057405be34b72617e93bf598b39a2ef11..cad7f99785eb1ef7ce5f52f1ca6f9092a6b3ca33 100644
--- a/content/browser/service_worker/embedded_worker_instance.cc
+++ b/content/browser/service_worker/embedded_worker_instance.cc
@@ -147,6 +147,7 @@ void EmbeddedWorkerInstance::Start(int64 service_worker_version_id,
status_ = STARTING;
starting_phase_ = ALLOCATING_PROCESS;
network_accessed_for_script_ = false;
+ FOR_EACH_OBSERVER(Listener, listener_list_, OnStarting());
scoped_ptr<EmbeddedWorkerMsg_StartWorker_Params> params(
new EmbeddedWorkerMsg_StartWorker_Params());
TRACE_EVENT_ASYNC_BEGIN2("ServiceWorker",
@@ -177,8 +178,10 @@ ServiceWorkerStatusCode EmbeddedWorkerInstance::Stop() {
DCHECK(status_ == STARTING || status_ == RUNNING) << status_;
ServiceWorkerStatusCode status =
registry_->StopWorker(process_id_, embedded_worker_id_);
- if (status == SERVICE_WORKER_OK)
+ if (status == SERVICE_WORKER_OK) {
status_ = STOPPING;
+ FOR_EACH_OBSERVER(Listener, listener_list_, OnStopping());
+ }
return status;
}
@@ -258,8 +261,10 @@ void EmbeddedWorkerInstance::ProcessAllocated(
params.get(),
"Status", status);
if (status != SERVICE_WORKER_OK) {
+ Status old_status = status_;
status_ = STOPPED;
callback.Run(status);
+ FOR_EACH_OBSERVER(Listener, listener_list_, OnStopped(old_status));
return;
}
const int64 service_worker_version_id = params->service_worker_version_id;

Powered by Google App Engine
This is Rietveld 408576698