Make ContentRendererClient::DidCreateScriptContext take a WebLocalFrame.

Make ContentRendererClient::DidCreateScriptContext take a WebLocalFrame.

Also extensions::Dispatcher::WillReleaseScriptContext.

R=nasko@chromium.org

Committed: https://crrev.com/974a50613d142a86cfa3c94bd9386d05029dabd0
Cr-Commit-Position: refs/heads/master@{#319739}

[not at google - send to devlin, 2015-03-06 20:28:58]

Is there a BUG this fits under? Pretty trivial change.

[nasko, 2015-03-07 00:42:17]

nasko@chromium.org changed reviewers:
+ dcheng@chromium.org

[nasko, 2015-03-07 00:42:18]

It looks fine to me. I don't think we will be creating any scripting contexts
for remote frames, but adding dcheng@ to keep me honest.

https://codereview.chromium.org/985643004/diff/20001/chrome/renderer/chrome_c...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/985643004/diff/20001/chrome/renderer/chrome_c...
chrome/renderer/chrome_content_renderer_client.cc:1387: WebLocalFrame* frame,
nit: blink::WebLocalFrame

[dcheng, 2015-03-07 14:21:32]

Blink will never send this callback for a remote frame. Internally, it
still creates a v8::Context (this is what provides the global object).

On Fri, Mar 6, 2015, 19:42 null <nasko@chromium.org> wrote:

> It looks fine to me. I don't think we will be creating any scripting
> contexts
> for remote frames, but adding dcheng@ to keep me honest.
>
>
> https://codereview.chromium.org/985643004/diff/20001/
> chrome/renderer/chrome_content_renderer_client.cc
> File chrome/renderer/chrome_content_renderer_client.cc (right):
>
> https://codereview.chromium.org/985643004/diff/20001/
> chrome/renderer/chrome_content_renderer_client.cc#newcode1387
> chrome/renderer/chrome_content_renderer_client.cc:1387
>
<https://codereview.chromium.org/985643004/diff/20001/chrome/renderer/chrome_c...>:
> WebLocalFrame*
> frame,
> nit: blink::WebLocalFrame
>
> https://codereview.chromium.org/985643004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[nasko, 2015-03-09 14:25:23]

LGTM with the existing nit.

[not at google - send to devlin, 2015-03-09 16:25:14]

https://codereview.chromium.org/985643004/diff/20001/chrome/renderer/chrome_c...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/985643004/diff/20001/chrome/renderer/chrome_c...
chrome/renderer/chrome_content_renderer_client.cc:1387: WebLocalFrame* frame,
On 2015/03/07 00:42:18, nasko wrote:
> nit: blink::WebLocalFrame

Done, and it bothered me enough to update the other instances of Web[Local]Frame
in this file.

[not at google - send to devlin, 2015-03-09 16:25:19]

The CQ bit was checked by kalman@chromium.org

[not at google - send to devlin, 2015-03-09 16:25:19]

The patchset sent to the CQ was uploaded after l-g-t-m from nasko@chromium.org
Link to the patchset: https://codereview.chromium.org/985643004/#ps40001 (title:
"namespace")

[commit-bot: I haz the power, 2015-03-09 16:25:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985643004/40001

[commit-bot: I haz the power, 2015-03-09 16:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-09 16:43:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[not at google - send to devlin, 2015-03-09 17:05:55]

kalman@chromium.org changed reviewers:
+ jochen@chromium.org

[not at google - send to devlin, 2015-03-09 17:05:56]

+jochen for chrome/renderer/chrome_content_renderer_client.cc

[not at google - send to devlin, 2015-03-09 21:38:11]

kalman@chromium.org changed reviewers:
+ thestig@chromium.org
- jochen@chromium.org

[not at google - send to devlin, 2015-03-09 21:38:22]

jochen --> thestig. Jochen is traveling.

[Lei Zhang, 2015-03-09 21:42:10]

chrome/ lgtm

[not at google - send to devlin, 2015-03-09 21:43:47]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2015-03-09 21:44:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985643004/40001

[commit-bot: I haz the power, 2015-03-09 22:02:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-09 22:03:09]

Patchset 3 (id:??) landed as
https://crrev.com/974a50613d142a86cfa3c94bd9386d05029dabd0
Cr-Commit-Position: refs/heads/master@{#319739}