[es6] Throw TypeError for computed static prototype property name

src/compiler/ast-graph-builder.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/ast-graph-builder.h"
 
 #include "src/compiler.h"
 #include "src/compiler/ast-loop-assignment-analyzer.h"
 #include "src/compiler/control-builders.h"
 #include "src/compiler/linkage.h"
@@ skipping 1365 matching lines @@
   environment()->Push(proto);
 
   // Create nodes to store method values into the literal.
   for (int i = 0; i < expr->properties()->length(); i++) {
     ObjectLiteral::Property* property = expr->properties()->at(i);
     environment()->Push(property->is_static() ? literal : proto);
 
     VisitForValue(property->key());
     environment()->Push(
         BuildToName(environment()->Pop(), expr->GetIdForProperty(i)));
+
+    // The static prototype property is read only. We handle the non computed
+    // property name case in the parser. Since this is the only case where we
+    // need to check for an own read only property we special case this so we do
+    // not need to do this for every property.
+    if (property->is_static() && property->is_computed_name()) {
+      Node* name = environment()->Pop();
+      const Operator* op =
+          javascript()->CallRuntime(Runtime::kThrowIfStaticPrototype, 1);

[arv (Not doing code reviews), 2015/03/06 11:51:29]

I'm tempted to do the `if (name === 'prototype') { ... }` here instead of doing
that in the runtime function.

[Michael Starzinger, 2015/03/06 13:05:18]

I would be fine with having the comparison inline if you like to go for it. You
could use JSStrictEqual and the IfBuilder to construct that. Check out
AstGraphBuilder::BuildStackCheck for inspiration on how this might look like.

[Dmitry Lomov (no reviews), 2015/03/09 14:46:04]

I think inline comparison is better overall since it is one runtime call less on
happy path. But ok either way.

+      Node* maybe_throw = NewNode(op, name);
+      PrepareFrameState(maybe_throw, expr->GetIdForProperty(i));
+      environment()->Push(maybe_throw);
+    }
+
     VisitForValue(property->value());
     Node* value = environment()->Pop();
     Node* key = environment()->Pop();
     Node* receiver = environment()->Pop();
     BuildSetHomeObject(value, receiver, property->value());
 
     switch (property->kind()) {
       case ObjectLiteral::Property::CONSTANT:
       case ObjectLiteral::Property::MATERIALIZED_LITERAL:
       case ObjectLiteral::Property::PROTOTYPE:
@@ skipping 1862 matching lines @@
     // Phi does not exist yet, introduce one.
     value = NewPhi(inputs, value, control);
     value->ReplaceInput(inputs - 1, other);
   }
   return value;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8