Adding telemetry test for page scroll using scrollbar drag.

Adding telemetry test for page scroll using scrollbar drag.

This CL adds a telemetry benchmark to use gmail page and uses the
scrollbar and mouss drag action to scroll the page. The test calculates
the mid-point of scrollbar and drags it till the end of the page.

BUG=464685
Committed: https://crrev.com/7b874423d6e08083a2b78cb61f5992c27c92cc2d
Cr-Commit-Position: refs/heads/master@{#319629}

[ssid, 2015-03-06 10:56:55]

ssid@chromium.org changed reviewers:
+ alexclarke@chromium.org, picksi@chromium.org, skyostil@chromium.org

[ssid, 2015-03-06 10:58:47]

PTAL.

[picksi, 2015-03-06 14:12:01]

Great! Looks good to me.

[alex clarke (OOO till 29th), 2015-03-06 14:14:38]

lgtm

[Sami, 2015-03-06 15:02:04]

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
File tools/perf/page_sets/top_25_smooth.py (right):

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:81: def CalculateScrollBarRatios(self,
action_runner):
nit: Start this name with an underscore since it's an internal helper.

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:82: display_height =
float(action_runner.EvaluateJavaScript(
I think you want .clientHeight here (and also rename display_height to something
like viewport_height).

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:84: page_height =
float(action_runner.EvaluateJavaScript(
nit: content_height?

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:88: scrollbar_width =
float(action_runner.EvaluateJavaScript('''
Add a comment here that this only works if the scrollable element has no border
or padding.

[ssid, 2015-03-06 16:45:55]

Made changed. PTAL.

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
File tools/perf/page_sets/top_25_smooth.py (right):

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:81: def CalculateScrollBarRatios(self,
action_runner):
On 2015/03/06 15:02:04, Sami wrote:
> nit: Start this name with an underscore since it's an internal helper.

Done.

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:82: display_height =
float(action_runner.EvaluateJavaScript(
On 2015/03/06 15:02:04, Sami wrote:
> I think you want .clientHeight here (and also rename display_height to
something
> like viewport_height).

Done.

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:84: page_height =
float(action_runner.EvaluateJavaScript(
On 2015/03/06 15:02:04, Sami wrote:
> nit: content_height?

Done.

https://codereview.chromium.org/985603003/diff/20001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:88: scrollbar_width =
float(action_runner.EvaluateJavaScript('''
On 2015/03/06 15:02:04, Sami wrote:
> Add a comment here that this only works if the scrollable element has no
border
> or padding.

Done.

[Sami, 2015-03-06 18:44:16]

lgtm with a nit.

https://codereview.chromium.org/985603003/diff/40001/tools/perf/page_sets/top...
File tools/perf/page_sets/top_25_smooth.py (right):

https://codereview.chromium.org/985603003/diff/40001/tools/perf/page_sets/top...
tools/perf/page_sets/top_25_smooth.py:92: # This calculation is correct only
when the scrollbar doesnt have border or
nit: it's not the scrollbar's border that matters, it's the border on the
element itself.

[ssid, 2015-03-09 11:45:22]

On 2015/03/06 18:44:16, Sami wrote:
> lgtm with a nit.
> 
>
https://codereview.chromium.org/985603003/diff/40001/tools/perf/page_sets/top...
> File tools/perf/page_sets/top_25_smooth.py (right):
> 
>
https://codereview.chromium.org/985603003/diff/40001/tools/perf/page_sets/top...
> tools/perf/page_sets/top_25_smooth.py:92: # This calculation is correct only
> when the scrollbar doesnt have border or
> nit: it's not the scrollbar's border that matters, it's the border on the
> element itself.

Thanks. Fixed.

[ssid, 2015-03-09 11:45:55]

The CQ bit was checked by ssid@chromium.org

[ssid, 2015-03-09 11:45:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexclarke@chromium.org, skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/985603003/#ps60001 (title:
"Fixed comment.")

[commit-bot: I haz the power, 2015-03-09 11:46:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985603003/60001

[commit-bot: I haz the power, 2015-03-09 14:44:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-09 14:45:26]

Patchset 4 (id:??) landed as
https://crrev.com/7b874423d6e08083a2b78cb61f5992c27c92cc2d
Cr-Commit-Position: refs/heads/master@{#319629}

[ssid, 2015-03-09 20:10:56]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/991963004/ by ssid@chromium.org.

The reason for reverting is: The test times out. Refer crbug.com/465446.