Thin library for interacting with the GAE datastore metadata entities.

Thin library for interacting with the GAE datastore metadata entities.

Only implements the one function I need right now, but can be extended for
others as needed.

R=vadimsh@chromium.org
BUG=

Committed: https://chromium.googlesource.com/infra/infra/+/237f1b6e9a3fee33061014419c2d65153ba7c8bd

[Vadim Sh., 2015-03-06 03:01:48]

lgtm

https://codereview.chromium.org/985583003/diff/1/go/src/infra/gae/libs/meta/e...
File go/src/infra/gae/libs/meta/eg.go (right):

https://codereview.chromium.org/985583003/diff/1/go/src/infra/gae/libs/meta/e...
go/src/infra/gae/libs/meta/eg.go:38: err = mark(err)
nit: 'mark' is too general. It is ok in such small file, but in larger file it
may get ambiguous...

How do you feel about standardizing on some name like "markError" or "pkgError",
and (maybe) standartaize on making it package global (not file global), e.g.

var makeError = errors.MakeMarkFn("infra/gae/libs/meta")

?

[iannucci, 2015-03-07 02:32:19]

On 2015/03/06 at 03:01:48, vadimsh wrote:
> lgtm
> 
>
https://codereview.chromium.org/985583003/diff/1/go/src/infra/gae/libs/meta/e...
> File go/src/infra/gae/libs/meta/eg.go (right):
> 
>
https://codereview.chromium.org/985583003/diff/1/go/src/infra/gae/libs/meta/e...
> go/src/infra/gae/libs/meta/eg.go:38: err = mark(err)
> nit: 'mark' is too general. It is ok in such small file, but in larger file it
may get ambiguous...
> 
> How do you feel about standardizing on some name like "markError" or
"pkgError", and (maybe) standartaize on making it package global (not file
global), e.g.
> 
> var makeError = errors.MakeMarkFn("infra/gae/libs/meta")
> 
> ?

that sgtm, though remember it's chromium.googlesource.com/........ :P

I actually got this idea/trivial implementation from some other package
somewhere that had it as an internal detail....

[iannucci, 2015-03-07 02:32:40]

On 2015/03/07 at 02:32:19, iannucci wrote:
> On 2015/03/06 at 03:01:48, vadimsh wrote:
> > lgtm
> > 
> >
https://codereview.chromium.org/985583003/diff/1/go/src/infra/gae/libs/meta/e...
> > File go/src/infra/gae/libs/meta/eg.go (right):
> > 
> >
https://codereview.chromium.org/985583003/diff/1/go/src/infra/gae/libs/meta/e...
> > go/src/infra/gae/libs/meta/eg.go:38: err = mark(err)
> > nit: 'mark' is too general. It is ok in such small file, but in larger file
it may get ambiguous...
> > 
> > How do you feel about standardizing on some name like "markError" or
"pkgError", and (maybe) standartaize on making it package global (not file
global), e.g.
> > 
> > var makeError = errors.MakeMarkFn("infra/gae/libs/meta")
> > 
> > ?
> 
> that sgtm, though remember it's chromium.googlesource.com/........ :P
> 
> I actually got this idea/trivial implementation from some other package
somewhere that had it as an internal detail....

committing it as-is, it's easier to change later.

[iannucci, 2015-03-07 02:32:41]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2015-03-07 02:33:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985583003/1

[commit-bot: I haz the power, 2015-03-07 03:00:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 03:00:56]

Try jobs failed on following builders:
  infra_tester on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/infra_tester/bu...)

[iannucci, 2015-03-12 01:10:58]

The CQ bit was checked by iannucci@chromium.org

[iannucci, 2015-03-12 01:10:59]

The patchset sent to the CQ was uploaded after l-g-t-m from vadimsh@chromium.org
Link to the patchset: https://codereview.chromium.org/985583003/#ps20001 (title:
"Disable tests since they would simply test that dev_appserver correctly mocks
the real metadata obj…")

[commit-bot: I haz the power, 2015-03-12 01:11:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985583003/20001

[commit-bot: I haz the power, 2015-03-12 01:13:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/237f1b6e9a3fee33061014419c2d6...