chrome/browser/web_applications/web_app_mac.mm - Issue 985573003: Support 32-bit subversion fields in base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/web_app_mac.mm

Issue 985573003: Support 32-bit subversion fields in base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rename back Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/web_applications/web_app_mac.mm

diff --git a/chrome/browser/web_applications/web_app_mac.mm b/chrome/browser/web_applications/web_app_mac.mm

index 799407a5dfb484f3df0f0bf3ee3ca27fcd9be320..3c0a1a4f40dc8394a638717fbf7748817d86133c 100644

--- a/chrome/browser/web_applications/web_app_mac.mm

+++ b/chrome/browser/web_applications/web_app_mac.mm

@@ -502,7 +502,7 @@ web_app::ShortcutInfo RecordAppShimErrorAndBuildShortcutInfo(

NSDictionary* plist = ReadPlist(GetPlistPath(bundle_path));

base::Version full_version(base::SysNSStringToUTF8(

[plist valueForKey:app_mode::kCFBundleShortVersionStringKey]));

- int major_version = 0;

+ unsigned int major_version = 0;

Nico 2015/03/09 14:21:57 why not uint32_t here too?

Will Harris 2015/03/09 22:52:18 Done.

if (full_version.IsValid())

major_version = full_version.components()[0];

UMA_HISTOGRAM_SPARSE_SLOWLY("Apps.AppShimErrorVersion", major_version);