Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3637)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/version_unittest.cc

Issue 985573003: Support 32-bit subversion fields in base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename back Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/version.cc ('K') | « base/version.cc ('k') | chrome/browser/component_updater/pepper_flash_component_installer.cc » ('j') | chrome/browser/web_applications/web_app_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/version_unittest.cc
diff --git a/base/version_unittest.cc b/base/version_unittest.cc
index 46d8255d15379d7a7553043e4bd1ab0972b6498b..b84359dfe0441a211ff6b8e6cd891e2fd71472b4 100644
--- a/base/version_unittest.cc
+++ b/base/version_unittest.cc
@@ -43,7 +43,8 @@ TEST(VersionTest, GetVersionFromString) {
{"0", 1, true},
{"0.", 0, false},
{"0.0", 2, true},
- {"65537.0", 0, false},
+ {"4294967295.0", 2, true},
+ {"4294967296.0", 0, false},
{"-1.0", 0, false},
{"1.-1.0", 0, false},
{"1,--1.0", 0, false},
@@ -57,6 +58,7 @@ TEST(VersionTest, GetVersionFromString) {
{"0.01", 2, true},
{"f.1", 0, false},
{"15.007.20011", 3, true},
+ {"15.5.28.130162", 4, true},
};
for (size_t i = 0; i < arraysize(cases); ++i) {
« base/version.cc ('K') | « base/version.cc ('k') | chrome/browser/component_updater/pepper_flash_component_installer.cc » ('j') | chrome/browser/web_applications/web_app_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698