Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: base/version.h

Issue 985573003: Support 32-bit subversion fields in base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename back Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/version.cc » ('j') | base/version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/version.h
diff --git a/base/version.h b/base/version.h
index b3012eb921b1e62a803b681f03954fbb17d14cea..a486eaeae7be541a8fe034a2798e17a39bfbc305 100644
--- a/base/version.h
+++ b/base/version.h
@@ -57,10 +57,10 @@ class BASE_EXPORT Version {
// Return the string representation of this version.
const std::string GetString() const;
- const std::vector<uint16>& components() const { return components_; }
+ const std::vector<uint32>& components() const { return components_; }
grt (UTC plus 2) 2015/03/09 13:19:49 please use uint32_t (and #include <stdint.h>) as p
Will Harris 2015/03/09 22:52:18 Done.
private:
- std::vector<uint16> components_;
+ std::vector<uint32> components_;
};
} // namespace base
« no previous file with comments | « no previous file | base/version.cc » ('j') | base/version.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698