chrome/browser/google/google_update_win_unittest.cc - Issue 985573003: Support 32-bit subversion fields in base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/google/google_update_win_unittest.cc

Issue 985573003: Support 32-bit subversion fields in base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a static assert Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/google/google_update_win_unittest.cc

diff --git a/chrome/browser/google/google_update_win_unittest.cc b/chrome/browser/google/google_update_win_unittest.cc

index 82f2e69bc64fa6d5e3d129d7cd93f97e8655c251..97498e4b03e2b81fd87f3b732953d65a82833789 100644

--- a/chrome/browser/google/google_update_win_unittest.cc

+++ b/chrome/browser/google/google_update_win_unittest.cc

@@ -344,7 +344,7 @@ class GoogleUpdateWinTest : public ::testing::TestWithParam<bool> {

// Compute a newer version.

base::Version current_version(CHROME_VERSION_STRING);

- new_version_ = base::StringPrintf(L"%hu.%hu.%hu.%hu",

+ new_version_ = base::StringPrintf(L"%u.%u.%u.%u",

current_version.components()[0],

current_version.components()[1],

current_version.components()[2] + 1,