chrome/browser/component_updater/pepper_flash_component_installer.cc - Issue 985573003: Support 32-bit subversion fields in base::Version.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/component_updater/pepper_flash_component_installer.cc

Issue 985573003: Support 32-bit subversion fields in base::Version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a static assert Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/component_updater/pepper_flash_component_installer.cc

diff --git a/chrome/browser/component_updater/pepper_flash_component_installer.cc b/chrome/browser/component_updater/pepper_flash_component_installer.cc

index 529a0368bfba1a4907c5bb67f33e85c697f65718..7fbe7336d61ab2120b3bd7c711b32c392f146897 100644

--- a/chrome/browser/component_updater/pepper_flash_component_installer.cc

+++ b/chrome/browser/component_updater/pepper_flash_component_installer.cc

@@ -107,7 +107,7 @@ bool MakePepperFlashPluginInfo(const base::FilePath& flash_path,

content::PepperPluginInfo* plugin_info) {

if (!flash_version.IsValid())

return false;

- const std::vector<uint16_t> ver_nums = flash_version.components();

+ const std::vector<uint32_t> ver_nums = flash_version.components();

if (ver_nums.size() < 3)

return false;

« no previous file with comments | « base/version_unittest.cc ('k') | chrome/browser/component_updater/sw_reporter_installer_win.cc » ('j') | no next file with comments »