chrome/browser/resources/settings/a11y_page/demo.html - Issue 985533002: Set up serving infrastructure for c/b/r/settings.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/a11y_page/demo.html

Issue 985533002: Set up serving infrastructure for c/b/r/settings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unrelated changes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <link href="a11y_page.html" rel="import">	4 <link href="a11y_page.html" rel="import">

5 <link href="../prefs/prefs.html" rel="import">	5 <link href="../prefs/prefs.html" rel="import">

6 </head>	6 </head>

7 <body unresolved>	7 <body unresolved>

8 <cr-settings-prefs></cr-settings-prefs>	8 <cr-settings-prefs></cr-settings-prefs>

9 <cr-settings-a11y-page></cr-settings-a11y-page>	9 <cr-settings-a11y-page></cr-settings-a11y-page>

10 <script>	10 <script src="demo.js"></script>
	James Hawkins 2015/03/06 18:44:12 Is this required to be in the body? Is this required to be in the body? Jeremy Klein 2015/03/06 18:48:33 Nope. It's just a web-dev best practice to put scr Show quoted text On 2015/03/06 18:44:12, James Hawkins wrote: > Is this required to be in the body? Nope. It's just a web-dev best practice to put scripts at the bottom for loading speed, but it really really doesn't matter here. I guess I've been getting too used to Polymer html files :-). Moved to head.
11 var page = document.querySelector('cr-settings-a11y-page');

12 page.prefs = document.querySelector('cr-settings-prefs');

13 </script>

14 </body>	11 </body>

15 </html>	12 </html>

OLD	NEW