Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: testing/legion/rpc_methods.py

Issue 985503004: Removing the implicit delete from Terminate and Kill. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: testing/legion/rpc_methods.py
diff --git a/testing/legion/rpc_methods.py b/testing/legion/rpc_methods.py
index 7f17e2387e38b2e3c1bdd95e86fd031c74486481..970be220990fe19aca3cd85bd2191c2598fa365c 100644
--- a/testing/legion/rpc_methods.py
+++ b/testing/legion/rpc_methods.py
@@ -85,20 +85,20 @@ class Subprocess(object):
with cls._creation_lock:
key = 'Process%d' % cls._process_next_id
cls._process_next_id += 1
- logging.debug('Creating process %s', key)
+ logging.debug('Creating process %r', key)
process = cls(cmd)
cls._processes[key] = process
return key
@classmethod
def Terminate(cls, key):
- logging.debug('Terminating and deleting process %s', key)
- return cls._processes.pop(key).proc.terminate()
+ logging.debug('Terminating process %s', key)
+ return cls._processes[key].proc.terminate()
@classmethod
def Kill(cls, key):
- logging.debug('Killing and deleting process %s', key)
- return cls._processes.pop(key).proc.kill()
+ logging.debug('Killing process %s', key)
+ return cls._processes[key].proc.kill()
@classmethod
def Delete(cls, key):

Powered by Google App Engine
This is Rietveld 408576698