chrome/browser/autocomplete/zero_suggest_provider.cc - Issue 985503002: Omnibox - Make Omnibox Extensions Ignore Stop() Calls Due to User Idleness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/zero_suggest_provider.cc

Issue 985503002: Omnibox - Make Omnibox Extensions Ignore Stop() Calls Due to User Idleness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make unit tests compile Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/autocomplete/zero_suggest_provider.h ('k') | chrome/browser/autocomplete/zero_suggest_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/zero_suggest_provider.cc

diff --git a/chrome/browser/autocomplete/zero_suggest_provider.cc b/chrome/browser/autocomplete/zero_suggest_provider.cc

index c160dca31b07d4cb4e31876640b236616d8fed6a..ddd8a76feba85222fa1b1174e60642881b53b909 100644

--- a/chrome/browser/autocomplete/zero_suggest_provider.cc

+++ b/chrome/browser/autocomplete/zero_suggest_provider.cc

@@ -99,7 +99,7 @@ void ZeroSuggestProvider::Start(const AutocompleteInput& input,

input.type() == metrics::OmniboxInputType::INVALID)

return;

- Stop(true);

+ Stop(true, false);

field_trial_triggered_ = false;

field_trial_triggered_in_session_ = false;

results_from_cache_ = false;

@@ -146,7 +146,8 @@ void ZeroSuggestProvider::Start(const AutocompleteInput& input,

Run(suggest_url);

}

-void ZeroSuggestProvider::Stop(bool clear_cached_results) {

+void ZeroSuggestProvider::Stop(bool clear_cached_results,

+ bool due_to_user_inactivity) {

if (fetcher_)

LogOmniboxZeroSuggestRequest(ZERO_SUGGEST_REQUEST_INVALIDATED);

fetcher_.reset();