chrome/browser/autocomplete/history_url_provider.cc - Issue 985503002: Omnibox - Make Omnibox Extensions Ignore Stop() Calls Due to User Idleness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/autocomplete/history_url_provider.cc

Issue 985503002: Omnibox - Make Omnibox Extensions Ignore Stop() Calls Due to User Idleness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/autocomplete/autocomplete_controller.cc ('K') | « chrome/browser/autocomplete/history_url_provider.h ('k') | chrome/browser/autocomplete/zero_suggest_provider.h » ('j') | components/omnibox/autocomplete_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/autocomplete/history_url_provider.cc

diff --git a/chrome/browser/autocomplete/history_url_provider.cc b/chrome/browser/autocomplete/history_url_provider.cc

index ae6fba03d380efa3ec89ebeb2f55e6e31253874b..c9373bc720a58912639516abb12a744ccd443c02 100644

--- a/chrome/browser/autocomplete/history_url_provider.cc

+++ b/chrome/browser/autocomplete/history_url_provider.cc

@@ -493,7 +493,7 @@ void HistoryURLProvider::Start(const AutocompleteInput& input,

// re-run the query from scratch and ignore |minimal_changes|.

// Cancel any in-progress query.

- Stop(false);

+ Stop(false, false);

matches_.clear();

@@ -584,7 +584,8 @@ void HistoryURLProvider::Start(const AutocompleteInput& input,

}

-void HistoryURLProvider::Stop(bool clear_cached_results) {

+void HistoryURLProvider::Stop(bool clear_cached_results,

+ bool user_inactivity_timer) {

done_ = true;

if (params_)