Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: chrome/browser/autocomplete/autocomplete_controller.h

Issue 985503002: Omnibox - Make Omnibox Extensions Ignore Stop() Calls Due to User Idleness (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_ 6 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/gtest_prod_util.h" 10 #include "base/gtest_prod_util.h"
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 192
193 // Updates |done_| to be accurate with respect to current providers' statuses. 193 // Updates |done_| to be accurate with respect to current providers' statuses.
194 void CheckIfDone(); 194 void CheckIfDone();
195 195
196 // Starts |expire_timer_|. 196 // Starts |expire_timer_|.
197 void StartExpireTimer(); 197 void StartExpireTimer();
198 198
199 // Starts |stop_timer_|. 199 // Starts |stop_timer_|.
200 void StartStopTimer(); 200 void StartStopTimer();
201 201
202 // Helper function for Stop(). |user_inactivity_timer| means this call was
203 // triggered by a user's idleness, i.e., not an explicit user action.
204 void StopHelper(bool clear_result,
205 bool user_inactivity_timer);
Peter Kasting 2015/03/05 23:27:28 Nit: How about "due_to_user_inactivity" or "from_i
Mark P 2015/03/06 21:24:34 Good suggestions. Both are better than what I had
206
202 AutocompleteControllerDelegate* delegate_; 207 AutocompleteControllerDelegate* delegate_;
203 208
204 // A list of all providers. 209 // A list of all providers.
205 Providers providers_; 210 Providers providers_;
206 211
207 HistoryURLProvider* history_url_provider_; 212 HistoryURLProvider* history_url_provider_;
208 213
209 KeywordProvider* keyword_provider_; 214 KeywordProvider* keyword_provider_;
210 215
211 SearchProvider* search_provider_; 216 SearchProvider* search_provider_;
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
250 // Are we in Start()? This is used to avoid updating |result_| and sending 255 // Are we in Start()? This is used to avoid updating |result_| and sending
251 // notifications until Start() has been invoked on all providers. 256 // notifications until Start() has been invoked on all providers.
252 bool in_start_; 257 bool in_start_;
253 258
254 TemplateURLService* template_url_service_; 259 TemplateURLService* template_url_service_;
255 260
256 DISALLOW_COPY_AND_ASSIGN(AutocompleteController); 261 DISALLOW_COPY_AND_ASSIGN(AutocompleteController);
257 }; 262 };
258 263
259 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_ 264 #endif // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698