Makefile - Issue 98543008: Switch armv7 setting to arm_version=7 in v8 gyp files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Makefile

Issue 98543008: Switch armv7 setting to arm_version=7 in v8 gyp files (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: add arm_version makefile setting Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Makefile

diff --git a/Makefile b/Makefile

index d2c9a9dfacb57fe7b76aeee26e6477d250afac52..4ce771650e0f1e57ec8d8248598565c95b5990a9 100644

--- a/Makefile

+++ b/Makefile

@@ -138,12 +138,16 @@ ifeq ($(deprecationwarnings), on)

GYPFLAGS += -Dv8_deprecation_warnings=1

endif

# arm specific flags.

-# armv7=false/true

+# arm_version=<number | "default">

+ifneq ($(strip $(arm_version)),)

+ GYPFLAGS += -Darm_version=$(arm_version)

+else

+# Deprecated (use arm_version instead): armv7=false/true

ifeq ($(armv7), false)

- GYPFLAGS += -Darmv7=0

+ GYPFLAGS += -Darm_version=default

Jakob Kummerow 2013/12/11 11:28:24 IIUC, armv7=false used to result in armv6, so let'

else

ifeq ($(armv7), true)

- GYPFLAGS += -Darmv7=1

+ GYPFLAGS += -Darm_version=7

endif

# vfp2=off. Deprecated, use armfpu=

« no previous file with comments | « no previous file | build/android.gypi » ('j') | no next file with comments »