Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: build/toolchain.gypi

Issue 98543008: Switch armv7 setting to arm_version=7 in v8 gyp files (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/android.gypi ('K') | « build/standalone.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index 99f357a965a743863ce6c53bb77f8e137d6f8582..f902fd4d63e9a7dfb03e9ac9781e24bf072d5195 100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -92,10 +92,8 @@
'conditions': [
['armcompiler=="yes"', {
'conditions': [
- [ 'armv7==1', {
+ [ 'arm_version==7', {
'cflags': ['-march=armv7-a',],
- }],
- [ 'armv7==1 or armv7=="default"', {
'conditions': [
[ 'arm_neon==1', {
'cflags': ['-mfpu=neon',],
@@ -127,7 +125,7 @@
}, {
# armcompiler=="no"
'conditions': [
- [ 'armv7==1 or armv7=="default"', {
+ [ 'arm_version==7', {
'defines': [
'CAN_USE_ARMV7_INSTRUCTIONS=1',
],
@@ -180,10 +178,8 @@
'conditions': [
['armcompiler=="yes"', {
'conditions': [
- [ 'armv7==1', {
+ [ 'arm_version==7', {
'cflags': ['-march=armv7-a',],
- }],
- [ 'armv7==1 or armv7=="default"', {
'conditions': [
[ 'arm_neon==1', {
'cflags': ['-mfpu=neon',],
@@ -215,7 +211,7 @@
}, {
# armcompiler=="no"
'conditions': [
- [ 'armv7==1 or armv7=="default"', {
+ [ 'arm_version==7', {
'defines': [
'CAN_USE_ARMV7_INSTRUCTIONS=1',
],
« build/android.gypi ('K') | « build/standalone.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698