Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/renderer/extensions/webstore_bindings.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/webrtc_native_handler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/webstore_bindings.cc
diff --git a/chrome/renderer/extensions/webstore_bindings.cc b/chrome/renderer/extensions/webstore_bindings.cc
index 0176fd0ba8af27dfbbc9be379acf91b5fde7f3eb..ec5f5954cb85c56a0668bdd1bfb325634344df18 100644
--- a/chrome/renderer/extensions/webstore_bindings.cc
+++ b/chrome/renderer/extensions/webstore_bindings.cc
@@ -78,7 +78,7 @@ void WebstoreBindings::Install(
if (args[0]->IsString()) {
preferred_store_link_url = std::string(*v8::String::Utf8Value(args[0]));
} else {
- v8::ThrowException(v8::String::NewFromUtf8(
+ args.GetIsolate()->ThrowException(v8::String::NewFromUtf8(
args.GetIsolate(), kPreferredStoreLinkUrlNotAString));
return;
}
@@ -88,20 +88,20 @@ void WebstoreBindings::Install(
std::string error;
if (!GetWebstoreItemIdFromFrame(
frame, preferred_store_link_url, &webstore_item_id, &error)) {
- v8::ThrowException(
+ args.GetIsolate()->ThrowException(
v8::String::NewFromUtf8(args.GetIsolate(), error.c_str()));
return;
}
int install_id = g_next_install_id++;
if (!args[1]->IsUndefined() && !args[1]->IsFunction()) {
- v8::ThrowException(v8::String::NewFromUtf8(
+ args.GetIsolate()->ThrowException(v8::String::NewFromUtf8(
args.GetIsolate(), kSuccessCallbackNotAFunctionError));
return;
}
if (!args[2]->IsUndefined() && !args[2]->IsFunction()) {
- v8::ThrowException(v8::String::NewFromUtf8(
+ args.GetIsolate()->ThrowException(v8::String::NewFromUtf8(
args.GetIsolate(), kFailureCallbackNotAFunctionError));
return;
}
« no previous file with comments | « chrome/renderer/extensions/webrtc_native_handler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698