Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Unified Diff: chrome/renderer/extensions/webrtc_native_handler.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/v8_schema_registry.cc ('k') | chrome/renderer/extensions/webstore_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/webrtc_native_handler.cc
diff --git a/chrome/renderer/extensions/webrtc_native_handler.cc b/chrome/renderer/extensions/webrtc_native_handler.cc
index e75cb597dae873bfbdd457481f38dec1418cc0c7..ba04e98b912eead5b247dd72821b317d5c46aee4 100644
--- a/chrome/renderer/extensions/webrtc_native_handler.cc
+++ b/chrome/renderer/extensions/webrtc_native_handler.cc
@@ -226,13 +226,13 @@ void WebRtcNativeHandler::StartCastSendTransport(
scoped_ptr<Value> params_value(
converter->FromV8Value(args[1], context()->v8_context()));
if (!params_value) {
- v8::ThrowException(v8::Exception::TypeError(
+ args.GetIsolate()->ThrowException(v8::Exception::TypeError(
v8::String::NewFromUtf8(args.GetIsolate(), kUnableToConvertParams)));
return;
}
scoped_ptr<RtpParams> params = RtpParams::FromValue(*params_value);
if (!params) {
- v8::ThrowException(v8::Exception::TypeError(
+ args.GetIsolate()->ThrowException(v8::Exception::TypeError(
v8::String::NewFromUtf8(args.GetIsolate(), kInvalidRtpParams)));
return;
}
@@ -294,13 +294,13 @@ void WebRtcNativeHandler::StartCastUdpTransport(
scoped_ptr<Value> udp_params_value(
converter->FromV8Value(args[1], context()->v8_context()));
if (!udp_params_value) {
- v8::ThrowException(v8::Exception::TypeError(
+ args.GetIsolate()->ThrowException(v8::Exception::TypeError(
v8::String::NewFromUtf8(args.GetIsolate(), kUnableToConvertArgs)));
return;
}
scoped_ptr<UdpParams> udp_params = UdpParams::FromValue(*udp_params_value);
if (!udp_params) {
- v8::ThrowException(v8::Exception::TypeError(
+ args.GetIsolate()->ThrowException(v8::Exception::TypeError(
v8::String::NewFromUtf8(args.GetIsolate(), kInvalidUdpParams)));
return;
}
@@ -314,7 +314,7 @@ CastSendTransport* WebRtcNativeHandler::GetSendTransportOrThrow(
if (iter != send_transport_map_.end())
return iter->second.get();
v8::Isolate* isolate = context()->v8_context()->GetIsolate();
- v8::ThrowException(v8::Exception::RangeError(
+ isolate->ThrowException(v8::Exception::RangeError(
v8::String::NewFromUtf8(isolate, kSendTransportNotFound)));
return NULL;
}
@@ -326,7 +326,7 @@ CastUdpTransport* WebRtcNativeHandler::GetUdpTransportOrThrow(
if (iter != udp_transport_map_.end())
return iter->second.get();
v8::Isolate* isolate = context()->v8_context()->GetIsolate();
- v8::ThrowException(v8::Exception::RangeError(
+ isolate->ThrowException(v8::Exception::RangeError(
v8::String::NewFromUtf8(isolate, kUdpTransportNotFound)));
return NULL;
}
« no previous file with comments | « chrome/renderer/extensions/v8_schema_registry.cc ('k') | chrome/renderer/extensions/webstore_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698