Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1440)

Unified Diff: chrome/renderer/extensions/v8_schema_registry.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/extensions/unsafe_persistent.h ('k') | chrome/renderer/extensions/webrtc_native_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/v8_schema_registry.cc
diff --git a/chrome/renderer/extensions/v8_schema_registry.cc b/chrome/renderer/extensions/v8_schema_registry.cc
index e358b98604e086c74833b11ef7e893c90cf397d5..a56f7c2fc7f776a5f19f15aa53f23a60843a07bd 100644
--- a/chrome/renderer/extensions/v8_schema_registry.cc
+++ b/chrome/renderer/extensions/v8_schema_registry.cc
@@ -35,7 +35,7 @@ class SchemaRegistryNativeHandler : public ObjectBackedNativeHandler {
private:
void GetSchema(const v8::FunctionCallbackInfo<v8::Value>& args) {
args.GetReturnValue().Set(
- registry_->GetSchema(*v8::String::AsciiValue(args[0])));
+ registry_->GetSchema(*v8::String::Utf8Value(args[0])));
}
scoped_ptr<ChromeV8Context> context_;
@@ -66,16 +66,16 @@ scoped_ptr<NativeHandler> V8SchemaRegistry::AsNativeHandler() {
v8::Handle<v8::Array> V8SchemaRegistry::GetSchemas(
const std::vector<std::string>& apis) {
v8::Isolate* isolate = v8::Isolate::GetCurrent();
- v8::HandleScope handle_scope(isolate);
+ v8::EscapableHandleScope handle_scope(isolate);
v8::Context::Scope context_scope(GetOrCreateContext(isolate));
- v8::Handle<v8::Array> v8_apis(v8::Array::New(apis.size()));
+ v8::Local<v8::Array> v8_apis(v8::Array::New(isolate, apis.size()));
size_t api_index = 0;
for (std::vector<std::string>::const_iterator i = apis.begin();
i != apis.end(); ++i) {
v8_apis->Set(api_index++, GetSchema(*i));
}
- return handle_scope.Close(v8_apis);
+ return handle_scope.Escape(v8_apis);
}
v8::Handle<v8::Object> V8SchemaRegistry::GetSchema(const std::string& api) {
@@ -85,7 +85,7 @@ v8::Handle<v8::Object> V8SchemaRegistry::GetSchema(const std::string& api) {
return maybe_schema->second.newLocal(v8::Isolate::GetCurrent());
v8::Isolate* isolate = v8::Isolate::GetCurrent();
- v8::HandleScope handle_scope(isolate);
+ v8::EscapableHandleScope handle_scope(isolate);
v8::Handle<v8::Context> context = GetOrCreateContext(isolate);
v8::Context::Scope context_scope(context);
@@ -101,7 +101,7 @@ v8::Handle<v8::Object> V8SchemaRegistry::GetSchema(const std::string& api) {
v8::Local<v8::Object> to_return =
v8::Local<v8::Object>::New(isolate, v8_schema);
schema_cache_[api] = UnsafePersistent<v8::Object>(&v8_schema);
- return handle_scope.Close(to_return);
+ return handle_scope.Escape(to_return);
}
v8::Handle<v8::Context> V8SchemaRegistry::GetOrCreateContext(
« no previous file with comments | « chrome/renderer/extensions/unsafe_persistent.h ('k') | chrome/renderer/extensions/webrtc_native_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698