Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: chrome/renderer/extensions/logging_native_handler.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/logging_native_handler.cc
diff --git a/chrome/renderer/extensions/logging_native_handler.cc b/chrome/renderer/extensions/logging_native_handler.cc
index c97471b8d70b8b4c583cc26df135fe9f3dae6669..2abffaaaa6bff86c3bcac08dcf350c72f2c31ac1 100644
--- a/chrome/renderer/extensions/logging_native_handler.cc
+++ b/chrome/renderer/extensions/logging_native_handler.cc
@@ -49,13 +49,13 @@ void LoggingNativeHandler::DcheckIsOn(
void LoggingNativeHandler::Log(
const v8::FunctionCallbackInfo<v8::Value>& args) {
CHECK_EQ(1, args.Length());
- LOG(INFO) << *v8::String::AsciiValue(args[0]);
+ LOG(INFO) << *v8::String::Utf8Value(args[0]);
}
void LoggingNativeHandler::Warning(
const v8::FunctionCallbackInfo<v8::Value>& args) {
CHECK_EQ(1, args.Length());
- LOG(WARNING) << *v8::String::AsciiValue(args[0]);
+ LOG(WARNING) << *v8::String::Utf8Value(args[0]);
}
void LoggingNativeHandler::ParseArgs(
@@ -66,7 +66,7 @@ void LoggingNativeHandler::ParseArgs(
*check_value = args[0]->BooleanValue();
if (args.Length() == 2) {
*error_message = "Error: " + std::string(
- *v8::String::AsciiValue(args[1]));
+ *v8::String::Utf8Value(args[1]));
}
v8::Handle<v8::StackTrace> stack_trace =
@@ -91,7 +91,7 @@ std::string LoggingNativeHandler::ToStringOrDefault(
const std::string& dflt) {
if (v8_string.IsEmpty())
return dflt;
- std::string ascii_value = *v8::String::AsciiValue(v8_string);
+ std::string ascii_value = *v8::String::Utf8Value(v8_string);
return ascii_value.empty() ? dflt : ascii_value;
}
« no previous file with comments | « chrome/renderer/extensions/i18n_custom_bindings.cc ('k') | chrome/renderer/extensions/messaging_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698