Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4094)

Unified Diff: chrome/renderer/extensions/api_activity_logger.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: updates Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | chrome/renderer/extensions/app_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/api_activity_logger.cc
diff --git a/chrome/renderer/extensions/api_activity_logger.cc b/chrome/renderer/extensions/api_activity_logger.cc
index f42c1dfadc91782d34c9b8650eab05dd23f71e59..2ab900dc88b59643f6a28d586126a80309ab176a 100644
--- a/chrome/renderer/extensions/api_activity_logger.cc
+++ b/chrome/renderer/extensions/api_activity_logger.cc
@@ -43,11 +43,11 @@ void APIActivityLogger::LogInternal(
DCHECK(args[1]->IsString());
DCHECK(args[2]->IsArray());
- std::string ext_id = *v8::String::AsciiValue(args[0]);
+ std::string ext_id = *v8::String::Utf8Value(args[0]);
ExtensionHostMsg_APIActionOrEvent_Params params;
- params.api_call = *v8::String::AsciiValue(args[1]);
+ params.api_call = *v8::String::Utf8Value(args[1]);
if (args.Length() == 4) // Extras are optional.
- params.extra = *v8::String::AsciiValue(args[3]);
+ params.extra = *v8::String::Utf8Value(args[3]);
else
params.extra = "";
@@ -62,7 +62,7 @@ void APIActivityLogger::LogInternal(
for (size_t i = 0; i < arg_array->Length(); ++i) {
arg_list->Set(i,
converter->FromV8Value(arg_array->Get(i),
- v8::Context::GetCurrent()));
+ args.GetIsolate()->GetCurrentContext()));
}
params.arguments.Swap(arg_list.get());
}
« no previous file with comments | « PRESUBMIT.py ('k') | chrome/renderer/extensions/app_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698