chrome/renderer/extensions/unsafe_persistent.h - Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/unsafe_persistent.h

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/unsafe_persistent.h

diff --git a/chrome/renderer/extensions/unsafe_persistent.h b/chrome/renderer/extensions/unsafe_persistent.h

index 35704a863f590a8d1b8335a858e52a6427504813..f8fa9bbd42acfa9a57eb531dbb17c4b37ce49c38 100644

--- a/chrome/renderer/extensions/unsafe_persistent.h

+++ b/chrome/renderer/extensions/unsafe_persistent.h

@@ -31,7 +31,7 @@ template<typename T> class UnsafePersistent {

// V8_ALLOW_ACCESS_TO_RAW_HANDLE_CONSTRUCTOR to be defined

void dispose() {

v8::Persistent<T> handle(value_);

- handle.Dispose();

+ handle.Reset();

value_ = 0;

}