chrome/renderer/extensions/send_request_natives.cc - Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/send_request_natives.cc

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/send_request_natives.cc

diff --git a/chrome/renderer/extensions/send_request_natives.cc b/chrome/renderer/extensions/send_request_natives.cc

index db07d43c6aef901b8073584a445cfd70b77147e7..51c785583970accc0938c09424e8f726c46547a2 100644

--- a/chrome/renderer/extensions/send_request_natives.cc

+++ b/chrome/renderer/extensions/send_request_natives.cc

@@ -38,7 +38,7 @@ void SendRequestNatives::GetNextRequestId(

// callback will be dispatched to EventBindings::HandleResponse.

void SendRequestNatives::StartRequest(

const v8::FunctionCallbackInfo<v8::Value>& args) {

- std::string name = *v8::String::AsciiValue(args[0]);

+ std::string name = *v8::String::Utf8Value(args[0]);

int request_id = args[2]->Int32Value();

bool has_callback = args[3]->BooleanValue();

bool for_io_thread = args[4]->BooleanValue();