PRESUBMIT.py - Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 98543004: Remove usage of deprecated V8 APIs from c/r/extensions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index f861ab5ab6c8fcfa4ca78cc96103de38df1660e7..79f37bd64c22a6b112367f9402fd2ec2532a7823 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -835,6 +835,8 @@ def _CheckSpamLogging(input_api, output_api):

_TEST_CODE_EXCLUDED_PATHS +

input_api.DEFAULT_BLACK_LIST +

(r"^base[\\\/]logging\.h$",

+ r"^chrome[\\\/]renderer[\\\\/]extensions[\\\/]"

marja 2013/12/02 13:36:21 What's this, and why?

jochen (gone - plz use gerrit) 2013/12/02 13:45:12 the logging handler uses LOG(INFO), so I'm adding

Jói 2013/12/02 13:48:33 \\\\ -> \\\ (middle one)

+ r"logging_native_handler\.cc",

r"^remoting[\\\/]base[\\\/]logging\.h$",

r"^sandbox[\\\/]linux[\\\/].*",))

source_file_filter = lambda x: input_api.FilterSourceFile(