content/browser/devtools/worker_devtools_agent_host.h - Issue 985343002: DevTools: remove the WorkerDevToolsManager base - implementations are diverging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/worker_devtools_agent_host.h

Issue 985343002: DevTools: remove the WorkerDevToolsManager base - implementations are diverging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: comments addressed. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/shared_worker_devtools_manager_unittest.cc ('k') | content/browser/devtools/worker_devtools_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/worker_devtools_agent_host.h

diff --git a/content/browser/devtools/worker_devtools_agent_host.h b/content/browser/devtools/worker_devtools_agent_host.h

index 34750edb94b09fd5d123f1929752aa345cfd3e64..c7b07030e6d9cd3dc59ecbd0a800c8c5a152f50e 100644

--- a/content/browser/devtools/worker_devtools_agent_host.h

+++ b/content/browser/devtools/worker_devtools_agent_host.h

@@ -6,7 +6,6 @@

#define CONTENT_BROWSER_DEVTOOLS_WORKER_DEVTOOLS_AGENT_HOST_H_

#include "content/browser/devtools/ipc_devtools_agent_host.h"

-#include "content/browser/devtools/worker_devtools_manager.h"

#include "ipc/ipc_listener.h"

namespace content {

@@ -17,7 +16,7 @@ class SharedWorkerInstance;

class WorkerDevToolsAgentHost : public IPCDevToolsAgentHost,

public IPC::Listener {

public:

- typedef WorkerDevToolsManager::WorkerId WorkerId;

+ typedef std::pair<int, int> WorkerId;

// DevToolsAgentHost override.

bool IsWorker() const override;