Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Unified Diff: content/browser/devtools/shared_worker_devtools_manager.h

Issue 985343002: DevTools: remove the WorkerDevToolsManager base - implementations are diverging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/shared_worker_devtools_manager.h
diff --git a/content/browser/devtools/shared_worker_devtools_manager.h b/content/browser/devtools/shared_worker_devtools_manager.h
index 4d6c61645f3c4a81c118ceb73ee3469a2bb63193..4e5af855ac93cabfefac6ec7fbd87cf4c4644889 100644
--- a/content/browser/devtools/shared_worker_devtools_manager.h
+++ b/content/browser/devtools/shared_worker_devtools_manager.h
@@ -5,29 +5,40 @@
#ifndef CONTENT_BROWSER_DEVTOOLS_SHARED_WORKER_DEVTOOLS_MANAGER_H_
#define CONTENT_BROWSER_DEVTOOLS_SHARED_WORKER_DEVTOOLS_MANAGER_H_
+#include <map>
+
#include "base/basictypes.h"
#include "base/gtest_prod_util.h"
#include "base/memory/singleton.h"
-#include "content/browser/devtools/worker_devtools_manager.h"
+#include "content/public/browser/devtools_agent_host.h"
namespace content {
+class DevToolsAgentHostImpl;
class SharedWorkerDevToolsAgentHost;
class SharedWorkerInstance;
// Manages WorkerDevToolsAgentHost's for Shared Workers.
// This class lives on UI thread.
-class CONTENT_EXPORT SharedWorkerDevToolsManager
- : public WorkerDevToolsManager {
+class CONTENT_EXPORT SharedWorkerDevToolsManager {
public:
+ typedef std::pair<int, int> WorkerId;
+
// Returns the SharedWorkerDevToolsManager singleton.
static SharedWorkerDevToolsManager* GetInstance();
+ DevToolsAgentHostImpl* GetDevToolsAgentHostForWorker(int worker_process_id,
+ int worker_route_id);
+ void AddAllAgentHosts(DevToolsAgentHost::List* result);
+
// Returns true when the worker must be paused on start because a DevTool
// window for the same former SharedWorkerInstance is still opened.
bool WorkerCreated(int worker_process_id,
int worker_route_id,
const SharedWorkerInstance& instance);
+ void WorkerReadyForInspection(int worker_process_id, int worker_route_id);
+ void WorkerDestroyed(int worker_process_id, int worker_route_id);
+ void RemoveInspectedWorkerData(WorkerId id);
private:
friend struct DefaultSingletonTraits<SharedWorkerDevToolsManager>;
@@ -36,12 +47,18 @@ class CONTENT_EXPORT SharedWorkerDevToolsManager
FRIEND_TEST_ALL_PREFIXES(SharedWorkerDevToolsManagerTest, BasicTest);
FRIEND_TEST_ALL_PREFIXES(SharedWorkerDevToolsManagerTest, AttachTest);
+ using AgentHostMap = std::map<WorkerId, SharedWorkerDevToolsAgentHost*>;
+
SharedWorkerDevToolsManager();
- ~SharedWorkerDevToolsManager() override;
+ ~SharedWorkerDevToolsManager();
AgentHostMap::iterator FindExistingWorkerAgentHost(
const SharedWorkerInstance& instance);
+ // Resets to its initial state as if newly created.
+ void ResetForTesting();
+
+ AgentHostMap workers_;
DISALLOW_COPY_AND_ASSIGN(SharedWorkerDevToolsManager);
};

Powered by Google App Engine
This is Rietveld 408576698