Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: content/browser/devtools/worker_devtools_manager.h

Issue 985343002: DevTools: remove the WorkerDevToolsManager base - implementations are diverging. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments addressed. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/worker_devtools_manager.h
diff --git a/content/browser/devtools/worker_devtools_manager.h b/content/browser/devtools/worker_devtools_manager.h
deleted file mode 100644
index faa8ce290cc31bf966cc691ca1b581d0d733d912..0000000000000000000000000000000000000000
--- a/content/browser/devtools/worker_devtools_manager.h
+++ /dev/null
@@ -1,70 +0,0 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CONTENT_BROWSER_DEVTOOLS_WORKER_DEVTOOLS_MANAGER_H_
-#define CONTENT_BROWSER_DEVTOOLS_WORKER_DEVTOOLS_MANAGER_H_
-
-#include <map>
-#include <vector>
-
-#include "base/basictypes.h"
-#include "base/memory/ref_counted.h"
-#include "base/observer_list.h"
-#include "content/common/content_export.h"
-
-namespace content {
-
-class DevToolsAgentHost;
-class DevToolsAgentHostImpl;
-class WorkerDevToolsAgentHost;
-
-// A base class of SharedWorkerDevToolsManager and ServiceWorkerDevToolsManager,
-// provides common default implementation for them.
-// This class lives on UI thread.
-class CONTENT_EXPORT WorkerDevToolsManager {
- public:
- typedef std::pair<int, int> WorkerId;
-
- class Observer {
- public:
- virtual void WorkerCreated(DevToolsAgentHost* host) {}
- virtual void WorkerDestroyed(DevToolsAgentHost* host) {}
-
- protected:
- virtual ~Observer() {}
- };
-
- DevToolsAgentHostImpl* GetDevToolsAgentHostForWorker(int worker_process_id,
- int worker_route_id);
- void AddAllAgentHosts(std::vector<scoped_refptr<DevToolsAgentHost>>* result);
- void WorkerReadyForInspection(int worker_process_id, int worker_route_id);
- void WorkerDestroyed(int worker_process_id, int worker_route_id);
-
- void AddObserver(Observer* observer);
- void RemoveObserver(Observer* observer);
-
- protected:
- using AgentHostMap = std::map<WorkerId, WorkerDevToolsAgentHost*>;
- friend class SharedWorkerDevToolsManagerTest;
-
- WorkerDevToolsManager();
- virtual ~WorkerDevToolsManager();
- void RemoveInspectedWorkerData(WorkerId id);
- void WorkerCreated(const WorkerId& id,
- WorkerDevToolsAgentHost* host);
- void WorkerRestarted(const WorkerId& id, const AgentHostMap::iterator& it);
- AgentHostMap& workers() { return workers_; }
-
- private:
- // Resets to its initial state as if newly created.
- void ResetForTesting();
-
- ObserverList<Observer> observer_list_;
- AgentHostMap workers_;
- DISALLOW_COPY_AND_ASSIGN(WorkerDevToolsManager);
-};
-
-} // namespace content
-
-#endif // CONTENT_BROWSER_DEVTOOLS_WORKER_DEVTOOLS_MANAGER_H_
« no previous file with comments | « content/browser/devtools/worker_devtools_agent_host.h ('k') | content/browser/devtools/worker_devtools_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698