Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 98533005: Handle @proxy classes in type checker. (Closed)

Created:
7 years ago by Johnni Winther
Modified:
7 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Handle @proxy classes in type checker. BUG=http://dartbug.com/15049 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=31011

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -30 lines) Patch
M sdk/lib/_internal/compiler/implementation/compiler.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/elements.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/elements/modelx.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 3 chunks +25 lines, -19 lines 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/dart_backend_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +2 lines, -1 line 0 comments Download
A + tests/compiler/dart2js/proxy_test.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/size_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/value_range_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +4 lines, -0 lines 0 comments Download
A tests/language/proxy2_test.dart View 1 chunk +27 lines, -0 lines 0 comments Download
A tests/language/proxy_test.dart View 1 chunk +26 lines, -0 lines 0 comments Download
M tests/utils/dummy_compiler_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/utils/recursive_import_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
7 years ago (2013-12-05 15:59:38 UTC) #1
karlklose
LGTM.
7 years ago (2013-12-09 13:14:51 UTC) #2
Johnni Winther
7 years ago (2013-12-10 09:35:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r31011 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698