Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 98523003: Implement "presentation" feature for window.open()

Created:
7 years ago by Dominik Röttsches
Modified:
7 years ago
Reviewers:
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, miu+watch_chromium.org
Base URL:
https://github.com/drott/cameo.git@presentationWindowSquashed
Visibility:
Public.

Description

Implement "presentation" feature for window.open() Add "presentation" feature for the window.open() call, which opens a new fullscreen browser window on the first found secondary display by adding a new window disposition and a new fullscreen mode for the Browser object. A new notification bubble text is added and shown in this case. The secondary browser window can be closed by pressing escape while focused, or by programmatically closing it from the opener page. (Not meant for review.) BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -10 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.h View 4 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller.cc View 7 chunks +29 lines, -3 lines 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.h View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_exit_bubble_type.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +32 lines, -2 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 3 chunks +7 lines, -1 line 0 comments Download
M ui/base/window_open_disposition_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/screen_mac.mm View 1 chunk +5 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698