chrome/browser/favicon/favicon_handler.h - Issue 9852012: Fix favicon exact match logic and add test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 9852012: Fix favicon exact match logic and add test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use GURL::ReplaceComponents Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/favicon/favicon_handler.h

diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h

index b892f068a47cb0438bd4db1ac4aa4852af644823..288b21ecb5eaa2f02847df9c37d8db6f7ea25540 100644

--- a/chrome/browser/favicon/favicon_handler.h

+++ b/chrome/browser/favicon/favicon_handler.h

@@ -115,6 +115,9 @@ class FaviconHandler {

bool errored,

const gfx::Image& image);

+ // For testing.

+ const std::deque<FaviconURL>& image_urls() const { return image_urls_; }

protected:

// These virtual methods make FaviconHandler testable and are overridden by

// TestFaviconHandler.

« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »