Change profile name textfield behaviour on tab

Change profile name textfield behaviour on tab

This prevents tabbing when the profile name textfield is empty,
which was missing in my earlier CL.

This also improves upon that CL by using a different method to catch
event, which means no longer having to take care of blurring.

BUG=457585
Committed: https://crrev.com/d876d6dbafefd3118b107846b25430dc7d10f073
Cr-Commit-Position: refs/heads/master@{#320124}

[wesleylancel, 2015-03-07 18:19:02]

wesleylancel@gmail.com changed reviewers:
+ groby@chromium.org, noms@google.com

[groby-ooo-7-16, 2015-03-10 23:58:56]

https://codereview.chromium.org/985193003/diff/1/chrome/browser/ui/cocoa/prof...
File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):

https://codereview.chromium.org/985193003/diff/1/chrome/browser/ui/cocoa/prof...
chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:751: -
(BOOL)control:(NSControl*)control
What if I _click_ outside of the text field?

[wesleylancel, 2015-03-11 11:23:42]

On 2015/03/10 23:58:56, groby wrote:
>
https://codereview.chromium.org/985193003/diff/1/chrome/browser/ui/cocoa/prof...
> File chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm (right):
> 
>
https://codereview.chromium.org/985193003/diff/1/chrome/browser/ui/cocoa/prof...
> chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm:751: -
> (BOOL)control:(NSControl*)control
> What if I _click_ outside of the text field?

Currently, nothing happens. That lines up with behaviour on Windows.

[groby-ooo-7-16, 2015-03-11 18:02:45]

I'll leave it to noms to decide if that's desired behavior. I'd think not, but
she'd know the definitive answer.

noms@?

[noms (inactive), 2015-03-11 18:06:45]

On 2015/03/11 18:02:45, groby wrote:
> I'll leave it to noms to decide if that's desired behavior. I'd think not, but
> she'd know the definitive answer.
> 
> noms@?

On both Win/Mac, clicking anywhere outside the text field does not de-activate
the textfield. Since that's been around for a year and got no complains, I'm
kind of tempted to leave it as it is (or fix it as part of a different crbug,
but not smoosh it into this one).

[groby-ooo-7-16, 2015-03-11 18:14:30]

Grumble. LGTM, since it's not a regression and fixes an actual issue, but filed
https://code.google.com/p/chromium/issues/detail?id=466220

[wesleylancel, 2015-03-11 18:20:13]

The CQ bit was checked by wesleylancel@gmail.com

[commit-bot: I haz the power, 2015-03-11 18:21:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/985193003/1

[commit-bot: I haz the power, 2015-03-11 19:47:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-11 19:49:28]

Patchset 1 (id:??) landed as
https://crrev.com/d876d6dbafefd3118b107846b25430dc7d10f073
Cr-Commit-Position: refs/heads/master@{#320124}