ui/events/ozone/evdev/event_converter_evdev.cc - Issue 985163002: ozone: evdev: Fix possibility of stuck keys

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/events/ozone/evdev/event_converter_evdev.cc

Issue 985163002: ozone: evdev: Fix possibility of stuck keys (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/events/ozone/evdev/event_converter_evdev.cc

diff --git a/ui/events/ozone/evdev/event_converter_evdev.cc b/ui/events/ozone/evdev/event_converter_evdev.cc

index eda2e88527b46ba60b8ddfb4be38c0758d230415..fce8e9ca3753da617928c10c52c40e9b27532698 100644

--- a/ui/events/ozone/evdev/event_converter_evdev.cc

+++ b/ui/events/ozone/evdev/event_converter_evdev.cc

@@ -30,9 +30,12 @@ void EventConverterEvdev::Start() {

}

void EventConverterEvdev::Stop() {

- // TODO(spang): If we reach here due to an error, we should treat it

- // as if we have lost sync & release held keys, etc.

controller_.StopWatchingFileDescriptor();

+ OnStopped();

+void EventConverterEvdev::OnStopped() {

}

void EventConverterEvdev::OnFileCanWriteWithoutBlocking(int fd) {