extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc - Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc

Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extension-popup

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc

diff --git a/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc b/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc

index 32d44fb6707a1ce82e8936da8f0614e8353b673d..266f37960dfc8ffa4f482861fd42b3cb24f21708 100644

--- a/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc

+++ b/extensions/shell/browser/shell_web_contents_modal_dialog_manager.cc

@@ -8,7 +8,7 @@ namespace web_modal {

SingleWebContentsDialogManager*

WebContentsModalDialogManager::CreateNativeWebModalManager(

- NativeWebContentsModalDialog dialog,

+ gfx::NativeWindow dialog,

SingleWebContentsDialogManagerDelegate* native_delegate) {

// TODO(oshima): Investigate if we need to implement this.

NOTREACHED();

« no previous file with comments | « components/web_modal/web_contents_modal_dialog_manager_unittest.cc ('k') | no next file » | no next file with comments »