chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc - Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extension-popup

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h ('k') | chrome/browser/ui/webui/constrained_web_dialog_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

diff --git a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

index 481c2177d195f08df041737cbc14170ab8b266cd..fd60a4b0d6cce71e6b91bacac6bccee1e925abe6 100644

--- a/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

+++ b/chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc

@@ -85,8 +85,7 @@ void ConstrainedWebDialogDelegateBase::ReleaseWebContentsOnDialogClose() {

release_contents_on_close_ = true;

}

-web_modal::NativeWebContentsModalDialog

- ConstrainedWebDialogDelegateBase::GetNativeDialog() {

+gfx::NativeWindow ConstrainedWebDialogDelegateBase::GetNativeDialog() {

NOTREACHED();

return NULL;

}