chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc - Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

Issue 985133002: Remove NativeWebContentsModalDialog and NativePopup typedefs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@extension-popup

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/tabs/tab_strip_model_unittest.cc ('k') | chrome/browser/ui/views/web_contents_modal_dialog_manager_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

diff --git a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

index 3b20f0e134dcfdce866e1af44f65b1cfff375c33..586d47ac60d0658be78dc6284135a5446ee2c54d 100644

--- a/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

+++ b/chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc

@@ -124,7 +124,7 @@ class ConstrainedWebDialogDelegateViews

}

// ConstrainedWebDialogDelegate:

- web_modal::NativeWebContentsModalDialog GetNativeDialog() override {

+ gfx::NativeWindow GetNativeDialog() override {

return view_->GetWidget()->GetNativeWindow();

}

@@ -173,7 +173,7 @@ class ConstrainedWebDialogDelegateViewViews

void ReleaseWebContentsOnDialogClose() override {

return impl_->ReleaseWebContentsOnDialogClose();

}

- web_modal::NativeWebContentsModalDialog GetNativeDialog() override {

+ gfx::NativeWindow GetNativeDialog() override {

return impl_->GetNativeDialog();

}

content::WebContents* GetWebContents() override {