Issue 985123002: Move geocoder code to location related path. This CL only moves files, no functional change.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 985123002: Move geocoder code to location related path. This CL only moves files, no functional change. (Closed)

Created:
5 years, 9 months ago by alhaad

Modified:
5 years, 9 months ago

Reviewers:
hansmuller, hansmuller1

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move geocoder code to location related path. This CL only moves files, no functional change. R=hansmuller@google.com, hansmuller@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/4b5bda4536f6cfa9fec0c07992d2d8cfcfc3841f

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -308 lines)			Patch
M	examples/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	examples/js/README.md	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	examples/js/maps/BUILD.gn	View	1 chunk	+0 lines, -17 lines	0 comments	Download
D	examples/js/maps/demo.js	View	1 chunk	+0 lines, -79 lines	0 comments	Download
D	examples/js/maps/geocoder.mojom	View	1 chunk	+0 lines, -68 lines	0 comments	Download
D	examples/js/maps/geocoder_service.js	View	1 chunk	+0 lines, -128 lines	0 comments	Download
A +	examples/location/geocoder_demo.js	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	mojo/services/location/public/interfaces/BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	mojo/services/location/public/interfaces/geocoder.mojom	View	2 chunks	+3 lines, -6 lines	0 comments	Download
A +	services/location/geocoder_service.js	View	1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hansmuller1

LGTM. You might have left the demo in examples/js although if you're planning more location ...

5 years, 9 months ago (2015-03-06 20:17:07 UTC) #3

alhaad

5 years, 9 months ago (2015-03-06 21:59:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4b5bda4536f6cfa9fec0c07992d2d8cfcfc3841f (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages