Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9744)

Unified Diff: content/renderer/media/crypto/render_cdm_factory.cc

Issue 985113003: Block platform verification and file IO in the CDM adapter if the CDM configuration disallows them. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix DCHECK types. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/crypto/render_cdm_factory.cc
diff --git a/content/renderer/media/crypto/render_cdm_factory.cc b/content/renderer/media/crypto/render_cdm_factory.cc
index 2defedcc19b03fb0a072c54417c1d1587ce8007d..9e1f92d15442c1dca452917217dfe71144c5d533 100644
--- a/content/renderer/media/crypto/render_cdm_factory.cc
+++ b/content/renderer/media/crypto/render_cdm_factory.cc
@@ -36,6 +36,8 @@ RenderCdmFactory::~RenderCdmFactory() {
scoped_ptr<media::MediaKeys> RenderCdmFactory::Create(
const std::string& key_system,
+ bool allow_distinctive_identifier,
+ bool allow_persistent_state,
const GURL& security_origin,
const media::SessionMessageCB& session_message_cb,
const media::SessionClosedCB& session_closed_cb,
@@ -48,6 +50,10 @@ scoped_ptr<media::MediaKeys> RenderCdmFactory::Create(
// DCHECK(security_origin.is_valid());
if (media::CanUseAesDecryptor(key_system)) {
+ // TODO(sandersd): Currently the prefixed API always allows distinctive
+ // identifiers and persistent state. Once that changes we can sanity check
+ // here that neither is allowed for AesDecryptor, since it does not support
+ // them and should never be configured that way. http://crbug.com/455271
return scoped_ptr<media::MediaKeys>(new media::AesDecryptor(
session_message_cb, session_closed_cb, session_keys_change_cb));
}
@@ -55,6 +61,8 @@ scoped_ptr<media::MediaKeys> RenderCdmFactory::Create(
#if defined(ENABLE_PEPPER_CDMS)
return scoped_ptr<media::MediaKeys>(
PpapiDecryptor::Create(key_system,
+ allow_distinctive_identifier,
+ allow_persistent_state,
security_origin,
create_pepper_cdm_cb_,
session_message_cb,
@@ -63,6 +71,8 @@ scoped_ptr<media::MediaKeys> RenderCdmFactory::Create(
session_keys_change_cb,
session_expiration_update_cb));
#elif defined(ENABLE_BROWSER_CDMS)
+ DCHECK(allow_distinctive_identifier);
+ DCHECK(allow_persistent_state);
return scoped_ptr<media::MediaKeys>(
ProxyMediaKeys::Create(key_system,
security_origin,
« no previous file with comments | « content/renderer/media/crypto/render_cdm_factory.h ('k') | content/renderer/pepper/content_decryptor_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698