Fix up Owner settings on first load

chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <queue>
 #include <utility>
 
 #include "base/macros.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/run_loop.h"
 #include "base/test/scoped_path_override.h"
 #include "base/values.h"
 #include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos.h"
 #include "chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h"
+#include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_provider.h"
 #include "chrome/browser/chromeos/settings/device_settings_test_helper.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/test/base/scoped_testing_local_state.h"
 #include "chrome/test/base/testing_browser_process.h"
 #include "chrome/test/base/testing_profile.h"
 #include "chromeos/settings/cros_settings_names.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace em = enterprise_management;
@@ skipping 57 matching lines @@
 class OwnerSettingsServiceChromeOSTest : public DeviceSettingsTestBase {
  public:
   OwnerSettingsServiceChromeOSTest()
       : service_(nullptr),
         local_state_(TestingBrowserProcess::GetGlobal()),
         user_data_dir_override_(chrome::DIR_USER_DATA),
         management_settings_set_(false) {}
 
   void SetUp() override {
     DeviceSettingsTestBase::SetUp();
+
     provider_.reset(new DeviceSettingsProvider(base::Bind(&OnPrefChanged),
                                                &device_settings_service_));
     owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());
     InitOwner(device_policy_.policy_data().username(), true);
     FlushDeviceSettings();
 
     service_ = OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(
         profile_.get());
     ASSERT_TRUE(service_);
     ASSERT_TRUE(service_->IsOwner());
 
     device_policy_.policy_data().set_management_mode(
         em::PolicyData::LOCAL_OWNER);
     device_policy_.Build();
     device_settings_test_helper_.set_policy_blob(device_policy_.GetBlob());
     ReloadDeviceSettings();
   }
 
-  void TearDown() override { DeviceSettingsTestBase::TearDown(); }
+  void TearDown() override {
+    DeviceSettingsTestBase::TearDown();
+  }
 
   void TestSingleSet(OwnerSettingsServiceChromeOS* service,
                      const std::string& setting,
                      const base::Value& in_value) {
     PrefsChecker checker(service, provider_.get());
     checker.Set(setting, in_value);
     FlushDeviceSettings();
     checker.Wait();
   }
 
   void OnManagementSettingsSet(bool success) {
     management_settings_set_ = success;
   }
 
+ protected:
   OwnerSettingsServiceChromeOS* service_;
   ScopedTestingLocalState local_state_;
   scoped_ptr<DeviceSettingsProvider> provider_;
   base::ScopedPathOverride user_data_dir_override_;
   bool management_settings_set_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(OwnerSettingsServiceChromeOSTest);
 };
 
@@ skipping 178 matching lines @@
   void TearDown() override { DeviceSettingsTestBase::TearDown(); }
 
  private:
   DISALLOW_COPY_AND_ASSIGN(OwnerSettingsServiceChromeOSNoOwnerTest);
 };
 
 TEST_F(OwnerSettingsServiceChromeOSNoOwnerTest, SingleSetTest) {
   ASSERT_FALSE(service_->SetBoolean(kAccountsPrefAllowGuest, false));
 }
 
+class OwnerSettingsServiceChromeOSTakeOwnerTest
+    : public OwnerSettingsServiceChromeOSTest {
+ public:
+  OwnerSettingsServiceChromeOSTakeOwnerTest() {}
+  ~OwnerSettingsServiceChromeOSTakeOwnerTest() override {}
+
+  void SetUp() override {
+    DeviceSettingsTestBase::SetUp();
+
+    owner_key_util_->SetPrivateKey(device_policy_.GetSigningKey());
+    InitOwner(device_policy_.policy_data().username(), false);
+    FlushDeviceSettings();
+
+    service_ = OwnerSettingsServiceChromeOSFactory::GetForBrowserContext(
+        profile_.get());
+    ASSERT_TRUE(service_);
+    ASSERT_FALSE(service_->IsOwner());
+
+    device_policy_.policy_data().set_management_mode(
+        em::PolicyData::LOCAL_OWNER);
+    device_policy_.Build();
+    device_settings_test_helper_.set_policy_blob(device_policy_.GetBlob());
+    ReloadDeviceSettings();
+  }
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(OwnerSettingsServiceChromeOSTakeOwnerTest);
+};
+
+TEST_F(OwnerSettingsServiceChromeOSTakeOwnerTest, SingleSetTest) {
+  bool wildcard_match = false;
+  EXPECT_FALSE(
+      cros_settings_.FindEmailInList(kAccountsPrefUsers,
+                                     device_policy_.policy_data().username(),
+                                     &wildcard_match));
+
+  base::RunLoop loop;
+  scoped_ptr<CrosSettings::ObserverSubscription> subscription =
+      cros_settings_.AddSettingsObserver(
+          kAccountsPrefUsers,
+          base::Bind(&base::RunLoop::Quit, base::Unretained(&loop)));
+  service_->OnTPMTokenReady(true);
+  ReloadDeviceSettings();
+  loop.Run();
+
+  wildcard_match = false;
+  EXPECT_TRUE(
+      cros_settings_.FindEmailInList(kAccountsPrefUsers,
+                                      device_policy_.policy_data().username(),
+                                      &wildcard_match));
+  EXPECT_FALSE(wildcard_match);
+}
 }  // namespace chromeos