Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 985073003: [DevTools] Pass remoteBase query param to frontend. (Closed)

Created:
5 years, 9 months ago by dgozman
Modified:
5 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Pass remoteBase query param to frontend. BUG=459167 Committed: https://crrev.com/f850769beda874d0ee46a5e37d8921a285b02553 Cr-Commit-Position: refs/heads/master@{#319858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/devtools/devtools_window.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dgozman
Take a look please.
5 years, 9 months ago (2015-03-06 16:58:10 UTC) #2
pfeldman
lgtm
5 years, 9 months ago (2015-03-10 10:09:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985073003/1
5 years, 9 months ago (2015-03-10 10:09:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 10:54:20 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 10:55:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f850769beda874d0ee46a5e37d8921a285b02553
Cr-Commit-Position: refs/heads/master@{#319858}

Powered by Google App Engine
This is Rietveld 408576698