Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 985073002: Add sdefresne@ as temporary OWNERS for //chrome/browser/favicon (Closed)

Created:
5 years, 9 months ago by sdefresne
Modified:
5 years, 9 months ago
Reviewers:
pkotwicz, sky, stevenjb
CC:
chromium-reviews, browser-components-watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@favicon_client
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add sdefresne@ as temporary OWNERS for //chrome/browser/favicon Swap sdefresne@ instead of blundell@ and droger@ as temporary OWNERS of chrome/browser/favicon during the componentization of the feature. BUG=359513 Committed: https://crrev.com/493302554ef180daba6dc1d1e377528a041072bb Cr-Commit-Position: refs/heads/master@{#319619}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/favicon/OWNERS View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
sdefresne
PTAL
5 years, 9 months ago (2015-03-06 15:55:08 UTC) #2
pkotwicz
LGTM git log doesn't show any recent work to componentize this particular feature by sdefresne@ ...
5 years, 9 months ago (2015-03-06 16:01:25 UTC) #3
sdefresne
On 2015/03/06 16:01:25, pkotwicz wrote: > LGTM > > git log doesn't show any recent ...
5 years, 9 months ago (2015-03-06 16:05:07 UTC) #4
sky
LGTM 2
5 years, 9 months ago (2015-03-06 18:22:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985073002/1
5 years, 9 months ago (2015-03-09 10:17:01 UTC) #7
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 10:39:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985073002/20001
5 years, 9 months ago (2015-03-09 11:01:27 UTC) #13
commit-bot: I haz the power
Failed to apply the patch.
5 years, 9 months ago (2015-03-09 11:24:15 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985073002/20001
5 years, 9 months ago (2015-03-09 13:17:05 UTC) #18
tfarina
I checked the cq box again.
5 years, 9 months ago (2015-03-09 13:17:20 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 13:17:45 UTC) #21
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:18:43 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/493302554ef180daba6dc1d1e377528a041072bb
Cr-Commit-Position: refs/heads/master@{#319619}

Powered by Google App Engine
This is Rietveld 408576698