|
|
DescriptionAdd sdefresne@ as temporary OWNERS for //chrome/browser/favicon
Swap sdefresne@ instead of blundell@ and droger@ as temporary OWNERS of
chrome/browser/favicon during the componentization of the feature.
BUG=359513
Committed: https://crrev.com/493302554ef180daba6dc1d1e377528a041072bb
Cr-Commit-Position: refs/heads/master@{#319619}
Patch Set 1 #Patch Set 2 : Rebase #
Messages
Total messages: 22 (10 generated)
sdefresne@chromium.org changed reviewers: + pkotwicz@chromium.org, sky@chromium.org, stevenjb@chromium.org
PTAL
LGTM git log doesn't show any recent work to componentize this particular feature by sdefresne@ though
On 2015/03/06 16:01:25, pkotwicz wrote: > LGTM > > git log doesn't show any recent work to componentize this particular feature by > sdefresne@ though The feature was blocked by the componentization of HistoryService which is almost complete (waiting for approval for BUILD.gn changes). I've got some CL in progress to componentize chrome/browser/favicon. Look there https://codereview.chromium.org/user/sdefresne@chromium.org for a list.
LGTM 2
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985073002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkotwicz@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/985073002/#ps20001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985073002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply the patch.
The CQ bit was unchecked by commit-bot@chromium.org
The CQ bit was checked by tfarina@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/985073002/20001
tfarina@chromium.org changed reviewers: - tfarina@chromium.org
I checked the cq box again.
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/493302554ef180daba6dc1d1e377528a041072bb Cr-Commit-Position: refs/heads/master@{#319619} |