Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: public/platform/modules/notifications/WebNotificationManager.h

Issue 985063002: Pass in the origin when closing a persistent notification. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/notifications/Notification.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/modules/notifications/WebNotificationManager.h
diff --git a/public/platform/modules/notifications/WebNotificationManager.h b/public/platform/modules/notifications/WebNotificationManager.h
index b2531457e42be38785466f84300d905022db189e..c193bcb911762c62434e007affc770a6644a2b39 100644
--- a/public/platform/modules/notifications/WebNotificationManager.h
+++ b/public/platform/modules/notifications/WebNotificationManager.h
@@ -30,13 +30,13 @@ public:
// Shows a persistent notification on the user's system. These notifications will have
// their events delivered to a Service Worker rather than the object's delegate. Will
// take ownership of the WebNotificationShowCallbacks object.
- virtual void showPersistent(const WebSerializedOrigin&, const WebNotificationData&, WebServiceWorkerRegistration*, WebNotificationShowCallbacks*) { }
+ virtual void showPersistent(const WebSerializedOrigin&, const WebNotificationData&, WebServiceWorkerRegistration*, WebNotificationShowCallbacks*) = 0;
// Closes a notification previously shown, and removes it if being shown.
virtual void close(WebNotificationDelegate*) = 0;
// Closes a persistent notification identified by its persistent notification Id.
- virtual void closePersistent(const WebString& persistentNotificationId) { }
+ virtual void closePersistent(const WebSerializedOrigin&, const WebString& persistentNotificationId) = 0;
// Indicates that the delegate object is being destroyed, and must no longer
// be used by the embedder to dispatch events.
« no previous file with comments | « Source/modules/notifications/Notification.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698